html and css

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello 👋. Congratulation on successfully completing your first challenge 🎉 ! !

  I have some recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • Avoid using <span> for entire blocks of text, <span> is an inline HTML element used to apply styles to specific parts of text without changing the structure or meaning, but this tag doesn't provide the same semantic value as other tags like paragraphs.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS 🎨:

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  MOHAMAD•60

  @mohamad-hajiloPosted 11 months ago

  Thank you Melvin, it was very useful and interesting. I will definitely correct it.

  1