HTML & CSS QR-Code-Challenge

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @kateneilsen, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  1.Add the alt text to improve the accessibility.The alt attribute provides alternative information for an image if a user for some reason cannot view it (because of slow connection, an error in the src attribute, or if the user uses a screen reader). ---> <img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor">

  2.Use relative units like rem or em instead of px to have a better performance when you page content resize in different screen and devices. REM and EM does not just apply to font size, but to all sizes as well. To save your time you can code you whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  3.The main heading have the tag <h2>, in this case its better you replace it with <h1> since this heading is the main title in this page. Remember that every page should have one <h1> to declare which is the most important title and that you should follow the hierarchy using the heading sequence h1, h2, h3, h4, h5 and never jump a level.

  4.Something that can be a time saver for you is to use a CSS RESET to remove all default settings for margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0