Skip to content
Submitted over 2 years ago

HTML & CSS | QR Code. Positioning and Styling.

Wolf Sketch•40
@angry-wolf-sketch
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Challenge was quite easier than i expected. However i got stuck at Responsive Resize using just CSS.

Community feedback

  • PhoenixDev22•16,950
    @PhoenixDev22Posted over 2 years ago

    Hi Wolf Sketch,

    Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

    • You should use <main> landmark to wrap the card and <footer> for the attribution. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
    • In my opinion, the image is an important content. The alternate text is needed on this image. The alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor not describes the image.
    • Page should contain <h1>. In this challenge, as it’s supposed to be a part of a whole page, you may use<h1> instead of <h3>.
    • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.
    • width: 300px; an explicit width is not a good way to have responsive layout . Consider using max-width to the card in rem instead .
    • In order to center the card on the middle of the page , you can use the flexbox properties and min-height: 100vh for the <body> add a little padding to the body that way it stops the card from hitting the edges of the browser instead of large margins .
    • Consider using rem and em units as they are flexible, specially for font size better to use rem. If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
    • Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.

    Overall, Excellent work! Hopefully this feedback helps.

    Marked as helpful
    0
    Wolf Sketch•40
    @angry-wolf-sketchPosted over 2 years ago

    @PhoenixDev22 Really Helpful and also a thorough explanation. Thank you for your feedback. I now have specific areas of my project on which i should focus on. ❤

    1
    PhoenixDev22•16,950
    @PhoenixDev22Posted over 2 years ago

    @angry-wolf-sketch Glad to help. Happy coding!

    0
  • cjdemille•500
    @cjdemillePosted over 2 years ago

    This is a really good first project. It displays and scales well.

    It doesn't have a huge impact on this project, but it would be cleaner code to wrap the card in a "main" tag.

    You might want to look into centering the card vertically (like in the example). I usually find it easiest to use flexbox for this.

    Marked as helpful
    0
    Wolf Sketch•40
    @angry-wolf-sketchPosted over 2 years ago

    @cjdemille Thanks for the tip. Much appreciated. I'd try to implement these two things from now onwards into my next projects. 😄

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord