Skip to content
Submitted almost 4 years ago

HTML and CSS Profile component

Mohamed Abdelnasser•60
@mohamedabdelnasser414
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Does the structure of HTML and CSS look fine? what do I need to improve? Thanks!

Community feedback

  • Jane•1,040
    @janegcaPosted almost 4 years ago

    Hi Mohamed, your code structure looks clean and straightforward, the only thing I noticed is that you hard coded all the sizing/margins/padding using pixels; while this works fine it can cause problems in designs that need to be more responsive so as an exercise I would try converting the pixels to rems, ems, and vw/vh values or combinations of those and see how they effect things.

    Nice job overall.

    1
    Mohamed Abdelnasser•60
    @mohamedabdelnasser414Posted almost 4 years ago

    Thanks, @janega! I have implemented your feedback. much appreciated :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord