Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters

Submitted

HTML and CSS only Solution to QR Code Challenge

cli3338198ā€¢ 10

@cli3338198

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I would try using CSS preprocessors.

What challenges did you encounter, and how did you overcome them?

Re-learned how to center a div!

What specific areas of your project would you like help with?

I need more practice with CSS.

Community feedback

Daniel šŸ›øā€¢ 44,230

@danielmrz-dev

Posted

Hello there!

Congrats on completing the challenge! āœ…

Your solution looks excellent!

I have just one suggestion:

  • Use <main> to wrap the main content instead of <main> and <section>.

šŸ“Œ The tag <section> would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

Unless you have a specific reason to use both, there's no need, considering that you can achieve the same result with only one. It also makes it easier positioning the elements inside.

This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

0
Mirko Bozzettoā€¢ 180

@mirkobozzetto

Posted

i have nothing to say about your code, it works perfectly, my preference is about creating separate file for the css, you should maybe try one day tailwind, it's fun and very practical ^^

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord