Design comparison
SolutionDesign
Solution retrospective
Please some check it this site's code thoroughly, and give me some thing that i have messed up in code, can be done easily
Community feedback
- @mattstuddertPosted over 4 years ago
Nice work on this challenge! Here are some pointers after taking a look at your code:
- You've got
h2
andh4
headings but noh1
orh3
. I'd recommend avoiding skipping heading levels unnecessarily. This can cause accessibility issues in the content hierarchy for screen reader users. So the main heading would be ah1
and the next level in the hierarchy would beh2
and so on. - In the "Why Us" region you've got a single paragraph of text. I'd say this is a list of features/benefits so a
ul
would be more appropriate. - Avoid using IDs as CSS selectors. They have high specificity and can't be reused on the page, so they're not good for the purpose of styling. Instead, I'd recommend sticking to class, attribute, pseudo, and type selectors. Using these will help keep your CSS more maintainable.
I hope this helps. Let me know if you have any questions!
1 - You've got
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord