Design comparison
Solution retrospective
Any feedback is welcomed :)
Community feedback
- @pikapikamartPosted over 3 years ago
Hey, great work on completing this challenge.
Suggestion/s would be that;
-
As I resize, there seems to appear an scrollbar at the bottom of the screen. This was caused by your declaration of
width: 1325px;
in yourmain
tag. I think what you are doing is limiting it right, instead you will usemax-width: 1325px
for that. This will make your element have a maximum of 1325px of width, but the initial width. Removing that declaration will remove the unwanted scrollbar. -
I think it will be better if you made your breakpoint a loot sooner, so that you layout will change before the body's width overlaps your component which is doing right now. So keeping that in mind will be really good.
So, whenever we create these layouts, we need to always inspect, using dev tools which is our friend(yes) in creating fine layouts in the web. Using them, and looking for the resolution where our elements gets destroyed or when a scrollbar appears of some sort.
But still, you did a good in this challenge^
0@luisPolanco25Posted over 3 years ago@pikamart Thanks! I'll keep that in mind for next challenges
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord