Submitted over 1 year ago

HTML and CSS

JorgGou•50

@jorgegouv

Preview site View code

This is a solution for...NFT preview card component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Community feedback

Ecem Gokdogan•9,380
@ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.

In order to fix the accessibility issues, you need to replace <div class="card"> with the <main> tag. :) You'd better use Semantic HTML, and you can also reach more information about it from Semantic HTML and Using Semantic HTML Tags Correctly.

Also, each main content needs to start with an h1 element, and also contain only one h1 element. Your accessibility report states the need for one main landmark. So, you need to use a <h1> element in the <main> tag instead of using <h3>. You can replace your <h3> Equilibrium #3429 </h3> element with the <h1> Equilibrium #3429 </h1> element.

Hope I am helpful. :)
1
Abdul Khaliq 🚀•72,560
@0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

So fix it by replacing the <div class="card"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

Every site must want at least one h1 element identifying and describing the main content of the page.

An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!
1
C H A R A N 🎯•2,670
@0xabdulPosted over 1 year ago
Hi JorgGou well congratulations on completing the NFT preview card component

A Few Feedback for improve your code and clear the Accessibility issue

IN HTML 📂 :

L A N D M A R K 🛠️

The main landmark should be a top-level landmark. When a page contains nested document and/or application roles (e.g. typically through the use of iframe and frame elements), each document or application role may have one main landmark. If a page includes more than one main landmark, each should have a unique label.

To Clear the Accessibility reports use the Semantic elements Or non - Semantic elements

Note This Elements are don't sikp

semantic elements : <aside> , <artical> , <main>, <header> ,<section><footer>, <form> ect..

non- semantic elements : <div> , <span> ect ...

for easy way to clear the Accessibility reports using non semantic elements Ex :

<body> <div class="container" role="main"> // All html code goes here : 📃 </div> </body>

Or

using semantic elements

Ex :

<header> should be put heading or logo📸 </header> <nav> //Links here </nav> <main> Main of the contents 📃 </main> <footer> ©copy right here📍 </footer>

HEADINGS ⚙️

The page must contain at least one h1 element identifying and describing the main content of the page. An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page so reason Accessibility reports occurred Ex : <h1> must </h1> I Recommend you Know fully one level heading📚 Click here

I Hope it's useful comment for you and Happy Coding Developer 😊
1

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord