QR code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag and <h3> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .card on the page using grid, replace the height in .container with min-height: 100vh. give the img a max-width of 100% instead of a width,

  There is no need to give h1 and p font-weight values. Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Héctor Martin Dama•240

  @HectorMartinDamaPosted over 1 year ago

  @Hassiai thanks for your comment.

  0
• 

  Mcjethro Kalu•70

  @YungKingJayyPosted almost 2 years ago

  Hello, nice job. I think changing your container from a div to a main tag should fix your accessibility issues. Also, I noticed you didn't add an alternate text to your logo. Overall yor solution looks great.

  Marked as helpful

  0

  ---

  

  Héctor Martin Dama•240

  @HectorMartinDamaPosted over 1 year ago

  @YungKingJayy thanks for your comment. I will change it.

  0