Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@HectorMartinDama

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Replace <div class="container"> with the main tag and <h3> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

To center .card on the page using grid, replace the height in .container with min-height: 100vh. give the img a max-width of 100% instead of a width,

There is no need to give h1 and p font-weight values. Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

@HectorMartinDama

Posted

@Hassiai thanks for your comment.

0

@YungKingJayy

Posted

Hello, nice job. I think changing your container from a div to a main tag should fix your accessibility issues. Also, I noticed you didn't add an alternate text to your logo. Overall yor solution looks great.

Marked as helpful

0

@HectorMartinDama

Posted

@YungKingJayy thanks for your comment. I will change it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord