Design comparison
SolutionDesign
Solution retrospective
Feedback would be nice
Community feedback
- @A-amonPosted over 3 years ago
Hello! Great work and so is the responsiveness~
I have a few suggestions:
-
To make it more organized/neat, add classes like .error instead of directly setting styles in JS. You can set the styles of the classes in CSS.
-
Use position:absolute for the error messages so that it doesn't affect the form's height when it appears.
-
Try checking out the third answer in https://stackoverflow.com/questions/2276463/how-can-i-get-form-data-with-javascript-jquery on how to get the form input values without using querySelector('input') yourself!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord