html and css grid

Community feedback

• 

  mycrochip•460

  @mycrochipPosted over 2 years ago

  Hello Jake, way to go!

  I commend your courage to try out using CSS grids in your projects this early. It's very commendable as this took me a while before I could use it in my projects.

  I however recommend that instead of using a grid layout to map the entire layout of your page, you should only use them for arranging sibling components for now (like the reviews and ratings).

  I checked out your CSS source code and found out that the excess whitespace on your web rendering would most possibly be because of your grid template columns and grid template rows. You set a lot of them (so I felt this was an attempt to lay out the whole page using grids).

  By the way, the accessibility and validation issues counts on your submission are scary 😲. It turns out that a lot of images were used in this project. A simple fix would be to give all your images an "alt" attribute 😉.

  Good luck on your future submissions and happy coding!

  Marked as helpful

  1

  ---

  

  jake•140

  @jakewebdPosted over 2 years ago

  @mycrochip so i should have used multiple grids for each section of the page and just used regular positioning to place the grids?

  0

  

  mycrochip•460

  @mycrochipPosted over 2 years ago

  @jakewebd if you meant using grids for only page sections (for this design), then, yes.

  0