Design comparison
Community feedback
- @stuartbradleyPosted 1 day ago
Your html is well commented. You could however work on your structuring and formatting of your code. There are a couple of instances where there are line breaks between tags that don't need to be there and hinder readability.
Its good you are including media queries, however they dont seem to work as intended. Using browser tools, I changed the width of the page and the card outline stays intact. However the text and images fall out of line of the card and it becomes skewed.
Marked as helpful0 - @AdrianoEscarabotePosted about 12 hours ago
Hi Gentlefrank, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:
You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader.
The rest is excellent.
I hope you find it useful. 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord