@i-prkr
Posted
I really liked your solution and how you have used pure css and particularly variables for really clean and well-structured code,. It has helped me to see how I can be writing better css for my own projects!
The layout looks great on all screen sizes and spot on with the design, well done.
It looked like there was extra spacing on the right side of the card, and possibly cutting a bit of the right side of the image and preventing the corners being rounded correctly. Adding align-self: center; to the image appeared to correct this. Interested to see what you think - I believe your skills are a bit above my own!
Thanks for a nice solution.
@mickoymouse
Posted
@i-prkr Thank you for the detailed feedback.
You're right. I've missed that. Thank you for pointing it out. I've opted out in just filling the width and height to span across its containing element. This way, the image wrapper and the image itself are the same size which I think makes sense on this scenario.
I've updated the css to correct this. Thank you!
