HTML & CSS Flexbox

Community feedback

• 

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  Hi Makker,

  I have checked your project, mainly HTML and RWD by inspector in my browser:

  • this is a single page component so it will be good to use the h1 tag here: for example h1 with two spans inside (main-heading and sub-heading);
  • instead of div container you can add the tag main or put him below the header so you will indicate the main content; also instead of div class="cards"> you can use the section tag;
  • at the moment it is hard to read your HTML structure because you didn't add spacing to the elements (write your better structurally like a book);
  • names of the classes are not very readable.
  • RWD: till 900px you have got still one column (mobiles), what do you think about tablets => maybe it will better to create two rows with two boxes each and then go to the desktop design pattern?
  • add overflow hidden to the body (eliminate the scroll).

  Cheers :D

  2

  ---

  

  makker47•220

  @makker47Posted almost 4 years ago

  @SzymonRojek thanks for your review, I'm new on html and css and I do a lot of mistakes, sometimes I get lost in my code :D I know, I need work on this tags, I found everyday something new, but problem I can't remember everything :D for me still dark forest :) thanks again for your review, your review help me see what I do wrong ;)

  1

  

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  @makker47

  Hi again,

  You don't have to see it as mistakes. I learn like you, just keep coding but just do it slowly, do not rush => think predictively. These challenges look simple but they are not. I could do now landing page, or pages but I prefer to learn new things slowly, read a lot. Also, you do not have to remember everything: the key is searching, digging for information, that's one of the best skill! :D

  1

  

  Szymon Rojek•4,540

  @SzymonRojekPosted almost 4 years ago

  @SzymonRojek

  I have read this article => SEMANTIC HTML FOR MEANINGFUL WEBPAGES, I think it will be good to read so I am sharing it with you.

  Cheers! :D

  0