Html & Css - Flexbox

Community feedback

• 

  Zienab Mohammed Abdelmonaem•400

  @zenab12Posted over 2 years ago

  Hey!! Congratulations for completing this challenge.. .

  Here are my suggestions..

  1-use <main> tag and wrap <div class="card"></div> inside it to make code semantic

  2-Go down orderly when you are using the headings h1 down to h2 down to h3 and so on . so use h1 instead h3 and change font-size if you want .. This should fix most of your accessibility issues

  Regardless you did amazing ,I checked your code on w3 validator and there is no errors or warning in your code and you wrote clean and responsive code using semantic name classes (this make code readable) and flexbox(responsive) so congratulations... hope you find this useful... Happy coding and nice day :-)!!!

  Marked as helpful

  0

  ---

  

  Amir Hashemi•480

  @AmirhosseinHashemiPosted over 2 years ago

  @zenab12 Thanks zenab for your great help. It was very important for me. I will use your advice.

  1

  

  Zienab Mohammed Abdelmonaem•400

  @zenab12Posted over 2 years ago

  @seyyeddev You are Welcome

  1
• 

  Praise Immanuel•250

  @PraiseImmanuelPosted over 2 years ago

  You did a nice work pal. You just had a few accessibility issues. I will advise you always add a (lang = "en-us") attribute to your HTML tag. I believe this link will help

  www.w3schools.com/html/html_accessibility.asp

  Marked as helpful

  0

  ---

  

  Amir Hashemi•480

  @AmirhosseinHashemiPosted over 2 years ago

  @PraiseImmanuel thank my bro . yes I will read this tutorial and use it.

  1

  

  Praise Immanuel•250

  @PraiseImmanuelPosted over 2 years ago

  @seyyeddev Yo! you're welcome.

  0
• 

  CyrusKabir•1,885

  @CyrusKabirPosted over 2 years ago

  Hello my dear friend ♥ you did good on this challenge and here some improvements for your component :

  • adding some transitions to your hover effects can make them smooth and better.
  • as you can see in hover state on your card img, your overlay opacity: 0.5 add some opacity to eye icon (svg) so in this design we can see the eye icon have not any opacity so here it's because of little difference between opacity and rgba or any color system with an alpha for opacity, and and you can read about this problem on this stackoverflow post difference between opacity and alpha.

  0