HTML and CSS flex Component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h1> so it can cause severe accessibility errors due to incorrect usage of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's three <h1> elements, like this <h1>SEDANS</h1>, you can preferably use <h2> instead of <h1>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">3-column preview card component</h1>

  ---

  • If you have any questions or need further clarification, you can always check out my submission for this challenge where i used this technique and feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Jean Silva•140

  @jeanvs96Posted over 1 year ago

  @0xAbdulKhalid thank you, I already used some of your tips!

  0
• Account deleted

  Hello Coder 😊

  Your solution is great✨ and congratulations on successfully completing a newbie challenge🎉

  and there is small suggestion that might be helpful for you

  Images are for decoration : The alt attribute provides alternative information for an image if a user for some reason cannot view it and screen readers use the alt attribute to convey the message about the image

  And when the image don't have a significant meaning or image is just there for decoration we don't write any value in alt attribute

  so feel free and remove alt attribute value

  <img src="./images/icon-sedans.svg" alt="">
  
  

  <h1> tag :

  It is mandatory to use a <h1> tag in your solution because <h1> tag is most important aspect in accessibility and it helps screen reader to navigate with your page in easy way

  And H1 tags also help Google to understand the structure of a page. So if you're using H1s as Google recommends for your page title or content heading, your H1 is effectively telling Google “here's what my page is about.

  And every page just have one tittle that's why just use <h1> tag only one time

  Hope that was helpful 😊

  0