HTML and CSS flex box

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted over 3 years ago

  @Syed-Ansar you've done good job on this one, looks nice and responds well. There are a few sublte things that would make your solution look even better.

  1. Add a hover state to your button, links and social icons in the footer, it takes no to do it and makes you solution much more interactive.

  2. Your social icons need to be wrapped in a <a> tag sine they must be clickable.

  3. From around 800px to 1000px the buttons in the header are tied togather, looks a bit off, add margin to one of them throught modifier.

  4. On desktop view the image in computer section is not positioned as specified in the design, it looks ok but I suggest you play around with margin or relative positioning to get it in right place.

  5. In you markup you need to improve the way name things, for the most part you a good job but in some places you use names like class="1", I suggest you spend some time learning about BEM.

  Happy Coding :)

  0

  ---

  

  Syed-Ansar•195

  @Syed-AnsarPosted over 3 years ago

  @MojtabaMosavi I will look at it. Thank you for your comments Mojtaba.!

  0