Travolgi 🍕• 31,420
@denielden
Posted
Hi Ehab, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
paddingtocardclass - remove
paddingfrommain-imgclass and setwidth: 100% - add
overflow: hiddentoimageclass - try to add a little
transitionon the element with hover effect - instead of using
pxtry to use relative units of measurement -> read here
Overall you did well :)
Hope this help and happy coding!
Marked as helpful
1
Ehab Nada• 120
@hopamnada
Posted
@denielden Thank you Daniel, I did all the points you mentioned, you are very helpful. how can I use relative units to the card width and keep it is size fixed at any screen width ?
1
Travolgi 🍕• 31,420
@denielden
Posted
@hopamnada You are welcome!
You can use exactly as you would with pixels. You can convert px to rem via online app or just go by eye.
Keep it up ;)
Marked as helpful
1
