Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Ehab, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
padding
tocard
class - remove
padding
frommain-img
class and setwidth: 100%
- add
overflow: hidden
toimage
class - try to add a little
transition
on the element with hover effect - instead of using
px
try to use relative units of measurement -> read here
Overall you did well :)
Hope this help and happy coding!
Marked as helpful1@hopamnadaPosted over 2 years ago@denielden Thank you Daniel, I did all the points you mentioned, you are very helpful. how can I use relative units to the card width and keep it is size fixed at any screen width ?
1@denieldenPosted over 2 years ago@hopamnada You are welcome!
You can use exactly as you would with pixels. You can convert
px
torem
via online app or just go by eye.Keep it up ;)
Marked as helpful1 - add
- @optimusprime202Posted over 2 years ago
Hey @hopamnada, You’ve just about got it.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord