Frontend Mentor | HTML & CSS coding challenge solution

Community feedback

Abdul Khaliq 🚀• 72,660

@0xabdulkhaliq

Posted about 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

For example:
The <main> element should include all content directly related to the page's main idea, so there should only be one per page
The <footer> typically contains information about the author of the section, copyright data or links to related documents.

So resolve the issue by replacing the <div class="wrapper"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

Tushar Biswas• 4,080

@itush

Posted about 1 year ago

Congratulations on completing the challenge! 🎉

Your solution looks nice to me :)

To reset default browser styles you may also add margin: 0; padding: 0;
Yes producing the overlay effect is bit tricky but you've nicely handle it with opacity. Also the background-blend-mode property may be used to produce the same effect, but I never tried it myself.

In my projects:

I always start with mobile-first workflow.
I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.

<body>
<main>
All content 
</main>
</body>

I Use relative units as much as possible and avoid absolute units whenever possible.
If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project(which you did). Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals and then move on to any framework or library.
I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! 🙌 To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:

📚🔍 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.

📚🔍 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements.

I hope you find these resources helpful in your coding adventures! 🤞

I'm eagerly looking forward to seeing the amazing projects you'll create in the future! 🚀💻

Keep up the fantastic work and happy hacking! 💪✨

Matthew Robinson• 40

@Mattrob10

Posted about 1 year ago

@itush

Thanks for the review - I can't believe I forgot the margin and padding on the styling. Too include, you and @0xAbdulKhalid are absolutely correct - I need to improve practices on removing plain divs into elements i.e. <main>, <section>, and <article>. I need to relearn to retain these best practices. Also grateful 🙏 + I fixed the changes 👨‍💻

Tushar Biswas• 4,080

@itush

Posted about 1 year ago

@Mattrob10

You are most welcome!

We all improve with practice.

Always happy to help :)

HTML & CSS

Design comparison

Solution retrospective

Community feedback

Please log in to post a comment

Join our Discord community