HTML and CSS card-component

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted almost 4 years ago

  This looks nice, good job! I particularly like the clean css and use of combinators for margin - did you get that snippet off Andy Bell / Heydon Pickering? It's a firm favourite of mine 👍

  Viewing on mobile I'm getting a lot of vertical scroll at the moment, but I couldn't see an obvious reason for that in the css.

  Two things I would recommend changing in this, but both very small:

  1. Alt text needs to be more meaningful, like the guys name

  2. The following html tags don't make sense for the content within them. Think about whether you would understand what content to expect under a heading that just read "80k" in a contents page. It can't make sense on its own

  // swap this
  <h4 class="title">80K</h4>
  <p class="subtitle">Followers</p>
  
  // For this
  <p>
    <span class="title">80K</span>
    <span class="subtitle">Followers</span>
  </p>
  

  I hope this all helps, keep on coding

  1

  ---

  

  Juan Benavides•90

  @jbbenavidesrPosted almost 4 years ago

  Thank you very much! I'll take it into account.

  And yes, I did get the flow from Andy Bell. I really enjoy to read what he has to say about css.

  0