@Agnik7
Posted
Hi,
Congratulations on completing the challenge!!🎉🎉🎉
I have some suggestions for you, which might be of help to you.
- Instead of assign the width of the card, assign the max-width, to make the card responsive.
Replace
.card{
width: 380px;
}
with
.card{
max-width:380px;
}
- The text Equilibrium #3429 is actually a heading. Therefore use an
h1
tag instead of ap
tag. Then you won't have to define the font-weight manually, and it will also get rid of the accessibility issues.
<h1>Equilibrium #3429</h1>
-
Provide an alt statement to the
img
tag. The alt tells the browser what to show if the image cannot be displayed. To learn more about alt, click here -
Tags like main, aside, article, nav are known as landmarks. Landmarks are special parts of the page, where screen readers and other assistive technologies can traverse to. It is always a good practice to provide landmarks in your code. Wrap the whole content of the body before the footer, inside the
main
tag. For more info on landmarks, click here. -
Instead of defining a class named footer, replace the last
div
tag with afooter
tag.
Hope this feedback helps you improve your skills. Have a nice day!!
Marked as helpful