@floweuphoria
Posted
Looks good
@floweuphoria
Posted
Looks good
@Islandstone89
Posted
Well done!
A few suggestions:
HTML:
Every webpage needs a <main>
that wraps all of the content, except for <header>
and footer>
. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap .container
in a <main>
.
The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."
I would change the heading to a <h2>
- a page should only have one <h1>
, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.
.attribution
should be a <footer>
, and you should use <p>
for the text inside.
CSS:
Including a CSS Reset at the top is good practice.
I like to add 1rem
of padding
on the body
, to ensure the card doesn't touch the edges on small screens.
Remove the width on the card.
max-width
on the card should be in rem - change it to 20rem
, which equals 320px
.
font-size
must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.
Since all of the text should be centered, you only need to set text-align: center
on the body, and remove it elsewhere. The children will inherit the value.
Paragraphs have a default value of font-weight: 400
, so there is no need to declare it.
On the image, add display: block
and change width
to max-width: 100%
- the max-width prevents it from overflowing its container.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord