Design comparison
Community feedback
- @RaitisVilumsPosted almost 3 years ago
Hello,
Good start, instead of id : <div id="inner-content">, try to use class : <div class="inner-content">, usually IDs are used in Java script, or you can use it for a special URL to link directly to an element. Also you should give hover effects on image and text, they are found in the design folder under the active-states.jpg.
Happy coding!
1@Mildness10Posted almost 3 years ago@RaitisVilums totally noted. thanks for the tip. will keep it in mind ahead of my next task
1 - @rsrclabPosted almost 3 years ago
Hi, @Mildness10 ~
Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.
Here are some of the tips I like to provide.
- Please try BEM for naming element classes. It will help you a lot on bigger projects.
- There is no hover effects on image and other elements. It's also one of challenging part here.
- Font sizes and spacings aren't the same with design. As a front-end developer, it's important to meet pixel-perfect requirements.
https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH
Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.
Cheers ~
1@Mildness10Posted almost 3 years ago@tymren608 wow. this was so helpful. all points have been noted. will definitely apply it in my next task. thanks a lot
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord