Skip to content
Submitted about 2 years ago

HTML and CSS

Osim•10
@I-Osim
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Just revising my HTML and CSS practices :)

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted about 2 years ago

    Hi @I-Osim 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

    Here are some suggestions you might consider:

    With semantic tags:

    <body>
   <main class="product-preview">
      . . .
   </main>
   <footer class="attribution">
      . . .
   </footer>
<body>
    • Remove "width: 1440px;" from the body element.
    • The <div> tag defines a division or section on a website. It is used to style a container with CSS, set special alignment, or position content. It might be more efficient to use the <p> tag; the <p> element represents paragraph-level content, usually text:
    <p class="product-details">A floral, solar and voluptuous interpretation composed by Olivier Polge, Perfumer-Creator for the House of CHANEL.</p>
    • Add an h1 tag to your solution. The <h1> element is the main heading on a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference)

    Solution:

    <h1 class="product-name">Gabrielle Essence Eau De Parfum</h1>

    I hope those tips will help you.

    Good job, and happy coding!

    Marked as helpful
    2
  • バレンタイン 😈•64,190
    @VCaramesPosted about 2 years ago

    Hey there! 👋 Here are some suggestions to help improve your code:

    • To better identify the main content of you site you will want to encase your entire component inside a Main Element.

    • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

    • This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.

    Here is an example of how it works: EXAMPLE

    Syntax:

      <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

    More Info:

    https://www.w3schools.com/html/html_images_picture.asp

    https://web.dev/learn/design/picture-element/

    • The name of the perfume , “Gabrielle Essence Eau De Parfum” is the most important content in your card so it should be wrapped in a Heading Element.

    • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include span element with an sr-only text explaining that this is the old price.

    If you have any questions or need further clarification, let me know.

    Happy Coding! 👻🎃

    Marked as helpful
    2
  • Randy Ochoa•40
    @SoyRandy708Posted about 2 years ago

    Te recomiendo usar display flex para que la card quede alineada en el centro y no se quede en una esquina cuando la pantalla sea mobile o menor a desktop. Tambien un media Querie para que cuando la pantalla sea de cierta longitud la card cambie de posicion.

    Marked as helpful
    2
  • Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    Hi Osim, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
    • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

    Example:

    body {
    margin: 0;
    padding: 0;
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
}

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord