html and css

Community feedback

• 

  Kawsar Ahmed Fahad•2,660

  @faha1999Posted about 2 years ago

  Hello, David Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

  • You might want to use semantic tags like the <main> to wrap your code, instead of div. like

  <main class="grid-container">
  </main>
  

  This would help improve accessibility.

  • remove the below code to the .grid-container. It will center everything

  .grid-container {
      /* margin: 30px auto; */
     /* padding: 0 auto;*/
  }
  

  I hope it will work. Happy coding.

  1

  ---

  

  David•80

  @DavetOluwapelumiPosted about 2 years ago

  @faha1999 Thanks, I really appreciate

  0
• 

  Joseph Fola•590

  @Fola-JoePosted about 2 years ago

  A great work you have here!

  Although, you should make use of the mobile image for the mobile view. You could add it alongside your desktop image in your html code and use this css code:

  @media screen and (max-width: 425px) { 
         .desktop-img {
                display: none;
         }
  }
  @media screen and (min-width: 426px) {
         .mobile-img {
                display: none;
         }
  }
  

  I hope this helps, happy coding!😀🎊

  1

  ---

  

  David•80

  @DavetOluwapelumiPosted about 2 years ago

  @Fola-Joe Thanks, I'm grateful

  0