Skip to content
Submitted over 3 years ago

HTML & CSS

Kerolous Amged•130
@Kokosalah45
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

i really need some feedback of how i could organize my code and stop making widths and heights everywhere thnx alot !

Community feedback

  • Natalia Bubiak•185
    @NataliaKiwibirdPosted over 3 years ago

    Hi Kerolous, First of all, read some more about accessibility, for example here https://web.dev/accessible/ . You should have only one <main> element and <footer> should include your attribution, not statistics. I've completed this challenge recently, so you can see my HTML semantic tags solution.

    It's much easier to size elements in CSS using rem (especially for fonts and paddings) instead of px. Here is a good starting point https://css-tricks.com/font-sizing-with-rem/ Also, practice Flexbox and Grid, because these tools make your code most responsive and will help you stop using widths and heights.

    Happy coding!

    Marked as helpful
    1
    Kerolous Amged•130
    @Kokosalah45Posted over 3 years ago

    @NataliaKiwibird i really appreciate the help if you want we can learn this things together sometimes i could use the extra hand <3

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord