Design comparison
SolutionDesign
Community feedback
- @mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>
or use semantics
2. it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
3.Add
alt=" "
to your<img>
tagsHope it helps:)...don't forget to mark it as helpful 👍
You can get more details here...click here
Marked as helpful0 - wrap everything in your body in
- @fatlindshehuPosted over 2 years ago
Hi,
You did good with the component, I would suggest changing a few things:
background
needs to be set on the body & make surebackground-size: cover;
in order to fill all the space.- The component position should not be
fixed
use flexbox instead place it in the center of the page. - If you're not familiar with
flexbox
check this tutorial LINK
With few changes I think the component would look great, so keep it up :)
Marked as helpful0@Maher0551071612Posted over 2 years ago@fatlindshehu Thanks a lot .I will follow what you've written.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord