Design comparison
Solution retrospective
the media query was an uphill task for me.
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Orji Michael, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
- Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.
- every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
The rest is great!
I hope it helps... 👍
Marked as helpful0@Xlence1624Posted about 2 years ago@AdrianoEscarabote thanks for your comment. I really appreciate your input.
1 - @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
To better specify the main content of you site you will want to encase your entire component inside a Main Element.
-
The statistics component is a list of statistics, so it should be built using an Unordered List along with a List Items Element.
-
This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful0@Xlence1624Posted about 2 years ago@vcarames thanks so much for your comments. It was really helpful.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord