Design comparison
Solution retrospective
All feedback is welcome! Thank you for your time! :)
Community feedback
- @mattstuddertPosted almost 5 years ago
Congrats on submitting your first solution, Mario! One recommendation I'd have would be to avoid using
top
,right
,left
, orbottom
properties for layout purposes. As you can see by the screenshot it can lead to odd layout issues. Instead, I'd recommend looking into Grid and Flexbox to help you laying out elements on the page.Let me know if you have any questions. Keep up the great work!
1@MarioPavlovic156Posted almost 5 years agoThank you for the feedback, Matt! I have finished Grid and Flexbox tutorials and will be posting corrections in a few days. Thank you for your time, it was REALLY helpful.
0@mattstuddertPosted almost 5 years ago@MarioPavlovic156 awesome, glad to hear it! Be sure to mention me when you make the changes and I'll take another look 👍
1@MarioPavlovic156Posted almost 5 years ago@mattstuddert Hey Matt, i have updated the solutions. Check them out and if possible let me know what can I improve. Thanks again!
0@mattstuddertPosted almost 5 years ago@MarioPavlovic156 much better, nice work! Just a quick note on your class names. I'd recommend giving elements more meaningful names. For example,
div class="div-1 div">
could be changed to<div class="supervisor card">
. This will help you and potentially any teammates on future projects identify elements and regions easier.1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord