HTML and CSS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 5 years ago

  Great work Shahmir, your solution looks really good. My only small recommendation would be to change the h1 to be a single element instead of two. It's best to only ever have a single h1 on the page for accessibility reasons. You could then add a span inside to separate the lines.

  Also, have you ever used min-width media queries instead of max-width? Using them has the benefit of loading in fewer styles for mobile users and it very often leads to less CSS as well. It could be worth a try on a future challenge!

  Keep up the great work! 👍

  0

  ---

  

  Shahmir Faisal•480

  @shahmirfaisalPosted almost 5 years ago

  @mattstuddert Thanks for your suggestions. I always create desktop first websites, min-width is also a good option. I will give it a shot :)

  0