Design comparison
Solution retrospective
The project was built base on basic html and css code , with that alone you can build it.
Community feedback
- @kimodev1990Posted 11 months ago
- To center your DIV container in the middle of your website:
body { display: flex; justify-content: center; align-items: center; min-height: 100vh; }
-
It's better in the future not to assign definite values such as in class .text-container
width: 250px
& in class .qr_codewidth: 250px --- height:250px
, It's better to give them percentage values in relative to size of container for better responsive design. -
Adding up with previous point, If you need to assign a value to an element , you could check on and use clamp ( ) method in your coding for font-size, width, etc., So your designed sizes will change according to the viewport dimensions having a responsive design and will be suitable for any device layout.
-
you'd like to wrap the image inside DIV for better design & code control.
Hope you find this Useful & Helpful.
Other than that, Really Nice work & keep Going on.
Marked as helpful0 - @HusseinSamyPosted 11 months ago
Greetings @M'I'E, 👋🏻
Fantastic progress on embarking on the journey toward your dream!
I'm thrilled to see your engagement with this platform to enhance your design skills. However, I have a brief recommendation regarding your commit messages. Consider adopting some conventions such as this; it will prove beneficial in your future career, especially when collaborating with teams.
Hope you find this valuable! 😇
Keep up the outstanding work, and enjoy your coding journey! 🚀
Marked as helpful0@MIE-CODEPosted 11 months ago@HusseinSamy the project was brief and simple so i did not have much to say , but thank though
1@HusseinSamyPosted 11 months ago@MIE-CODE absolutely! I'm making a suggestion that will help you in your future career.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord