HTML and CSS

Community feedback

• 

  mubizzy•1,520

  @mubizzyPosted over 2 years ago

  Excellent job on this challenge! your report has a few issues though:

  1. wrap everything in your body in <main> or use semantics

  2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

  Hope it helps:)...don't forget to mark it as helpful 👍

  You can get more details here...click here

  0
• 

  Angélique D. Faye•390

  @AngeliqueDFPosted over 2 years ago

  Hi @SOKOUDJOU-LEOPOLD!

  You should change the name of your qr-code.html to index.html then push changes to the repository. The project's GitHub page should then be online and functioning. Or at least, you will see any bug on the live version.

  As for your code, start with:

  • Use semantic HTML elements. This will improve accessiblity and SEO.
  • Reduce CSS selectors specificity. In such a small app it might not be such a problem, but it's good to get into the habit of using more specific selectors only when necessary.
  • Use more adapted CSS rules for the job.

  Some resources to help you:

  • https://developer.mozilla.org/en-US/docs/Web/HTML, here you can find a list of HTML elements available to you to structure the HTML.
  • https://developer.mozilla.org/en-US/docs/Web/CSS, to find more adapted CSS rules to achieve the layout you're trying to reproduce.

  Some tools to help you: If you don't know where to start, you can use tools such as Lighthouse to scan the page (the live version or the one on localhost, use the Google chrome extension) and get tips on what to improve.

  Hope this helps!

  0
• 

  Asmaa Elfatayry•870

  @asmaa-elfatayryPosted over 2 years ago

  hello SOKOUDJOU, You have some problems:

  first, you should use the same colors and style you will find this in the folders you download that named style. guide

  second in the src of the img you must write ../ before the path image-qr-code.png to correct it hope this link help you https://www.w3schools.com/Html/html_filepaths.asp

  third you should make a live site in GitHub and not take screen you can watch this video https://www.youtube.com/watch?v=o5g-lUuFgpg

  and finally to solve ACCESSIBILITY ISSUES you should put all the code of the body inside <main></main> tag

  0