Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Html and Css

@rolvera22

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I know is not perfect, but it is my best try for the moment. Im learning step by step. thank you!

Community feedback

@pikapikamart

Posted

Hey, really great job on this one. Layout in general looks great.

Some suggestions would be:

  • Avoid using height: 100vh on a large container especially on the body tag as this limits the element's height based on the remaining screen's height. Instead, use min-height: 100vh this takes full height but lets the element expand if needed.
  • Always have a main element to wrap the main content of your page. On this one, the .container selector should use main instead of div.
  • When using img always include the alt attribute because if you didn't include it, assistive tech will instead read the source path of the image.
  • On the circles background image on the card, use alt="' on it and add aria-hidden="true" attribute on the img. An image that is decorative only, always hide them by this method.
  • The alt for the person's image should be their name so use alt="Victor Crest".
  • The person's name should be a heading tag, because it is them that is the main content of the component. It could be for now a h1 or h2.
  • Also, when there is a text-content, do not just use span to wrap them, always use meaningful tag like p tag to wrap them. You can wrap the span inside the p tag as well.
  • Those 3 information below could use a ul element since those are "list" of information about the user.

If you have any queries just drop it here. Again, awesome work on this one.

Marked as helpful

1

Abdelilah 180

@abdeldevprojects

Posted

@pikamart Thank you for the tips <3

0

@rolvera22

Posted

@pikamart, awesome! thank you for the tip!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord