Raymart Pamplona• 16,120
@pikapikamart
Posted
Hey, really great job on this one. Layout in general looks great.
Some suggestions would be:
- Avoid using
height: 100vh
on a large container especially on thebody
tag as this limits the element's height based on the remaining screen's height. Instead, usemin-height: 100vh
this takes full height but lets the element expand if needed. - Always have a
main
element to wrap the main content of your page. On this one, the.container
selector should usemain
instead ofdiv
. - When using
img
always include thealt
attribute because if you didn't include it, assistive tech will instead read the source path of the image. - On the circles background image on the card, use
alt="'
on it and addaria-hidden="true"
attribute on theimg
. An image that is decorative only, always hide them by this method. - The
alt
for the person's image should be their name so usealt="Victor Crest"
. - The person's name should be a heading tag, because it is them that is the main content of the component. It could be for now a
h1
orh2
. - Also, when there is a text-content, do not just use
span
to wrap them, always use meaningful tag likep
tag to wrap them. You can wrap thespan
inside thep
tag as well. - Those 3 information below could use a
ul
element since those are "list" of information about the user.
If you have any queries just drop it here. Again, awesome work on this one.
Marked as helpful
1
Abdelilah• 180
@abdeldevprojects
Posted
@pikamart Thank you for the tips <3
0
Raul Olvera• 250
@rolvera22
Posted
@pikamart, awesome! thank you for the tip!
0