Design comparison
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS β οΈ:
- This solution lacks usage of
<h1>
so it can cause severe accessibility errors due to lack of level-one headings<h1>
- Every site must want only one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
- Example:
<h1 class="sr-only">Testimonials grid section</h1>
- If you have any questions or need further clarification, you can always check out
my submission
for another challenge where i used this technique and feel free to reach out to me.
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @VCaramesPosted over 1 year ago
Hey there! π Here are some suggestions to help improve your code:
- The profile images are not decorative β. Their
alt tag
should not be blank. It should state the personβs full name.
More Info:π
- For the testimonials, it is best β
to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:π
- The web development process can be made easier and expedite the process π by implementing a
CSS Reset
. Here are some examples that you can freely use π: Josh Comeau Reset, Eric Meyer Reset
- ALWAYS Implement a "Mobile First" approach π± > π₯
Mobile devices are now the dominant π way in which people browse the web. So when building your content, you will start building with small screen sizes (starting at 320px) and work your way to larger screens using
min-width
.More Info: π
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! πΎ
Marked as helpful0 - The profile images are not decorative β. Their
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord