P
VictorGerfaud• 210
@JamesLaviron
Posted
- Does the solution include semantic HTML?
Yes it does, nice use of semantic HTML here. You could add a main or a section.
- Is it accessible, and what improvements could be made?
It is.
- Does the layout look good on a range of screen sizes?
Yes it does look ok.
- Is the code well-structured, readable, and reusable?
Not at all. You have to use CSS variables in order to make it reusable on future components. You souldn't use tag selectors such as h2{} p{}. It is very bad for performances. Always use classes or IDs. Moreover you should use a code editor and an extension for code formatting in order to avoid issued syntaxes.
- Does the solution differ considerably from the design?
Yes it does, many differences.
0
Alex Enogiasun• 40
@Alex-Enogiasun
Posted
Thanks alot for your wonderful observations. I will reassess and re-design the task @JamesLaviron
0
