Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML and CSS

Nerdytoo 30

@olalemi

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi,

Would appreciate some feedback on my work please

Feel free...

Community feedback

T
Grace 29,310

@grace-snow

Posted

This needs quite a few changes I’m afraid. All quite easy fixes and important to learn

  • you need to use landmark elements (eg main and footer)
  • the attribution (challenge by…) should be within the footer, not in the card
  • it’s invalid to have paragraphs inside heading elements
  • there should only be one heading in this. Even if there were more headings, they would have to go in order
  • the alt text on the wrong code img is extremely important. The image is of a QR code, not ERROR.
  • font size must never be in px. Use rem so it scales properly
  • you shouldn’t need a media query on this. It’s actually making the component look broken on my mobile. If you want to stop component hitting screen edges on small screens make sure there is either a little margin on the card, or padding on the wrapper (eg body in this case)
  • similar to not relying for viewport units for sizing, it’s best not to use % for things like padding. You need to have control of the layout, but don’t know what % will always equate to. Better to use rem (or px if you’re not comfortable with using rem yet)

I hope this helps

Marked as helpful

0

Nerdytoo 30

@olalemi

Posted

@grace-snow Thanks for your feedback, really helpful, will make sure I affect the changes

0
LiBee 370

@Li-Bee

Posted

Looks good - couple of comments.

  • You need to add border radius to the card element
  • I would take out the <attribute> and put outside your card element
  • for you accessiblity issues report if you add <main> to the body that should help with the landmark issue.

Marked as helpful

0

Nerdytoo 30

@olalemi

Posted

@Li-Bee Thanks for your feedback, much appreciated

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord