HTML & CSS

Community feedback

• 

  jeevan-v-jijo•50

  @jeevan-v-jijoPosted 2 days ago

  Congrats on completing the challenge, hurray!

  Some suggestions

  CSS

  You have used internal CSS using the styles tag. It works for simple projects but as you do more complex projects it may seem like your code is too cluttering. Using external CSS and using the link tag to connect it to HTML can make your code look more modular.

  <fieldset>

  You have used this tag as the parent to all other tag in the card. Technically there is nothing wrong and it works, but I believe that it is generally used in form tag. If you want to group things as such you may use other tags like <main>, <section>, <article>.

  About centering

  I think your code went hay-wire in this matter.

  ---

  in the class field2:

  remove margin-top: 1%; margin-left: 32%;

  to position this container in the center of the page there are few techniques there is one:

  position: absolute;
  
  left: 50%;
  
  top: 50%;
  
  transform: translate(-50%,-50%);
  

  set these styles to your field2 class.

  and change this

  padding-left: 0px;
  

  to padding:10px; this would be better

  ---

  for the img:

  margin-right: 5px;
  margin-left: 7px;
  

  remove both, I think you did this through trial and error and found this to be pleasing.

  ---

  There may be error in my code too. please correct me if I am wrong. I am too a learner in this matter.

  0