HTML and CSS

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  Hey,

  It looks really good and pretty organised! There are some accessibility issues in the report which you can get rid of if you switched your h4 to h1, and wrapped everything in a <main> tag but it's not super important in such a small challenge.

  You should also give your image an alt text ("QR code" would be fine as an alt).

  Apart from this, all seems fine. Well done, and happy coding ^^

  1

  ---

  

  Himanshu Sahani•30

  @F-a-u-x-LPosted over 2 years ago

  @FluffyKas Thank you for taking out your time to provide the feedback

  This is what I understood from your feedback:

  1. There needs to be a h1 in a HTML doc as a good practice ie instead of h4 I should have use h1
  2. everything inside the body should be contained in a main block

  Correct me if I got these two points wrong.

  Thanks once again for the feedback, will keep these things in mind moving forward

  0

  

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 2 years ago

  @F-a-u-x-L

  1. Yes.

  2. Not necessarily, but in this case, yes. Depending on the content, you could have several different landmarks that help assistive devices navigate through your website. Some HTML elements, like <main>, <header>, <footer>, etc have ARIA landmark roles by default, so when you can it's encouraged to use them.

  I recommend watching this video to learn a bit more about document outline and heading levels. It's a great starting point.

  In the video description there are some more articles that I highly recommend checking out for more detailed explanation once you feel comfortable with it.

  As I said, this all might seem a bit irrelevant at this point, as it's just a small component but semantic markup and accessibility are important (and really huge) topics so learning them step by step is a good idea! You won't feel so overwhelmed that way ^^

  0

  

  Himanshu Sahani•30

  @F-a-u-x-LPosted over 2 years ago

  @FluffyKas

  Yes, I remember being told that I should use various HTML elements instead of just using a <div> everywhere because that makes the code more understandable. I will make sure to make it a habit.

  Thank you :)

  0