HTML And CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Saad Hisham•1,750

  @Saad-HishamPosted over 1 year ago

  Hello there!

  Great job on your work, it's almost perfect! I just noticed that you forgot to add a hover effect on the button. It would be great if you could change the background color and also make the cursor a pointer when hovering over the button.

  Here's an example of how you could achieve this:

  a:hover {
  cursor: pointer;
  background-image: linear-gradient(to bottom,hsl(252, 100%, 67%), hsl(241, 81%, 54%));
  }
  

  Also, I noticed that the box shadow is a little bit too dark. If you could lighten it up just a bit, it would look even better.

  Here's the updated CSS for the container:

  .container {
  display: flex;
  width: 800px;
  border-radius: 15px;
  box-shadow: 4px 4px 10px 0px rgba(229,233,244,0.5);
  -webkit-box-shadow: 4px 4px 10px 0px rgba(229,233,244,0.5);
  -moz-box-shadow: 4px 4px 10px 0px rgba(229,233,244,0.5);
  border-radius: 0rem 2rem 2rem 0rem;
  }
  

  Keep up the great work🔥

  Marked as helpful

  0