html and css

Community feedback

• 

  Giovani Oliveira•90

  @GiodosvaniPosted about 1 month ago

  Congrats for your solution!

  to get even closer to the design, you can add some details on your code!

  • First of all: naming classes, variables or IDs with good names it's really important! You should be capable to discover which class refer to which tag just by reading it's name

  • A good practice is to design your project on the "mobile's first workflow". What means you design first for Mobiles, and then for bigger screens. Use the Inspect page on your browser to see your website in the size of a smartphone. (also, your design is working Fine on 375px - that means Medium phones, but on really small phones (320px) it brokes)

  These tips are more general, but will help you to achieve what you want.

  0

  ---

  

  Aya khedr•180

  @AyakhedrPosted about 1 month ago

  @Giodosvani thanx alot for your review about classes names when i do the project i use all names i can so i creat another names for diffrent classes what names do you thing is good for classes? about small phone i will take it in my mind

  1

  

  Giovani Oliveira•90

  @GiodosvaniPosted about 1 month ago

  @Ayakhedr you can use more descriptive names

  i remember reading a class called "pho" or "son" in your code -- I suggest using a name that you know what it refers just by reading it If you have a <p> tag that writes a description of a picture, then name his class something like "description" the same logic is applied to variables on javascript

  heres some tips that i found seaching on google:

  • Use Intention-Revealing Names. The name of the variable, function, class, etc should be sufficient enough to understand its purpose.
  • Name Classes as Nouns.
  • Use Meaningful Distinction.
  • Use Pronounceable Names.
  • Use Searchable Names.
  • Avoid Encodings.

  In the case of this project, since are just one tag for each in the whole page, classes or IDs aren't really necessary, you can just use the tag itself (without the ".")

  Hope it helps! continue with the good job!

  0

  

  Aya khedr•180

  @AyakhedrPosted about 1 month ago

  @Giodosvani thanx for your review

  1