html and css

Community feedback

• 

  Jeuri Morel•1,385

  @JeuriMorelPosted over 2 years ago

  Hi Prince Rana, you did a great job overall! Nicely done. Here are a few areas where you can improve the solution:

  • First, notice that you have an accessibility issue in the report; to fix this, change
    <div class="main-container"></div> to this:
    <main class="main-container"></main>
    Document should have one main landmark and all page content should be contained by landmarks. To learn more, follow this link.
  • I see that in your reset you put box-sizing: 0;. As far as I know that does nothing. It should be box-sizing: border-box;
  • To get the image color closer to the design, try adding
    background-color: var(--accent); background-blend-mode: multiply;
    to the hero img div, and then lowering the opacity on the overlay to 0.25.

  Marked as helpful

  1