Design comparison
SolutionDesign
Solution retrospective
Open for suggestions. The best i could come up was this.
Community feedback
- @JeuriMorelPosted over 2 years ago
Hi Prince Rana, you did a great job overall! Nicely done. Here are a few areas where you can improve the solution:
- First, notice that you have an accessibility issue in the report; to fix this, change
<div class="main-container"></div>
to this:
<main class="main-container"></main>
Document should have one main landmark and all page content should be contained by landmarks. To learn more, follow this link. - I see that in your reset you put
box-sizing: 0;
. As far as I know that does nothing. It should bebox-sizing: border-box;
- To get the image color closer to the design, try adding
background-color: var(--accent); background-blend-mode: multiply;
to the hero img div, and then lowering the opacity on the overlay to 0.25.
Marked as helpful1 - First, notice that you have an accessibility issue in the report; to fix this, change
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord