Design comparison
SolutionDesign
Community feedback
- @DanonymousCoderPosted over 1 year ago
Nice work, keep grinding. You just need to add a border-radius to the image. increase the padding of the sub text. And reduce the size of the container holding the image and texts.
Marked as helpful0@professorkabirPosted over 1 year ago@DanonymousCoder thank you very much, i appreciate.
0 - @jchu51Posted over 1 year ago
Hi @professorkabir,
Great work!
A few minor suggestions:
- Address the code formatting,
prettier
. - Using media queries for mobile devices; currently, the QR code image appears too large on mobile screens.
@media only screen and (max-width: 600px) { .className { width: ... } }
- It might be beneficial to use 'rem' or 'em' units for font sizes, padding, and margins.
- Instead of relying on element selectors, consider using the class attribute more frequently for CSS styling.
0 - Address the code formatting,
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord