html and css

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Ivan, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • Centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • try to use flexbox to the body for center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Ivan Aguilar•30

  @Ivan96318Posted over 2 years ago

  @denielden

  Thanks for your great advice 👍

  1