Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
Swap the positions of the Main Element and Wrapper. The purpose of the Main Element is to identify the main content of your page. It is not the container of you component.
-
For the profile images Alt Tag Description, it should never* include the following keywords; “image” and “photo”.
-
The only headings in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a Paragraph Element.
-
The headings are being used incorrectly. You gave one of the testimonials an <h1> Heading and the ret an <h2> Heading. By doing so, you are stating that single testimonial is far more important than the rest of the testimonials. To correct this, you want to give it an <h2> Heading instead.
-
To enhance the semantics of your component, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord