Html and Css

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great work on this one. Layout looks fine in desktop, the mobile as well is fine. Though when resizing, the layout is being hidden which creates a horizontal scrollbar.

  Some other suggestions would be:

  • On the header element, I suggest you to use a fixed height on it, instead of using vh unit, this way, even if a user changes their screen's height, the header won't change it size and stays consistent, use rem unit on the height property.
  • The alt for the website logo should be alt="clipboard" since the website is called by that name. Also, when using alt attribute, avoid using words that relates to "graphic" like "logo, image, icon...", assistive tech will handle those for you.
  • Avoid using multiple h1 on a webpage, only use at least 1 h1 per page.
  • The other images as well could have used alt="" on them since those aren't really images that adds content, since all of them are just basically almost the same.

  FOOTER

  • Website logo should as well use alt="clipboard"
  • Those list of links are good since you are using ul on it, but, you are using too much ul element. You could only use 1 ul on it, then have 5 li since there are 5 links right, creating multiple ul on those will just confuse the users.
  • The social media links should be using anchor tag a because those are "links".
  • The social media links should also be wrapped inside ul element, since those are "list" of links as well.
  • Each a tag of the social media links should have aria-label attribute, on which the value corresponds to the social media that they are nesting. For example, on the facebook icon, the a tag would have aria-label="facebook", this way, users will know where this link would take them.

  Aside from those, the responsiveness could be improved. But still, you did great in here.

  Marked as helpful

  0

  ---

  

  Chit_Thet_Aung•195

  @ChitThetAungPosted about 3 years ago

  @pikamart Wow! Thanks you very much bro. I'm really enjoy to your suggestions.

  0