Design comparison
Solution retrospective
Any feedback on how I can improve my code and reduce unnecessary code is most welcome!
Community feedback
- @DudeldupsPosted over 1 year ago
Hello! :)
One thing I can see is you struggling with the quotation marks in the background. You can set the background position dynamically by using a percentage. Something like
top 80%
maybe? This way you don't have to use media queries for the background image at all.And look up some guides on responsiveness. Try to generally avoid using pixels in your code (maybe just for box shadows or border-radius). Use
em
for media queries.Also try to always stick with classnames as your CSS selectors. This way you keep the specificity on one level and avoid overwriting a rule or you end up wondering why the rule doesn't appy. mdn reference
Marked as helpful0@yaditya007Posted over 1 year ago@Dudeldups Ya, I should use percentages for positioning. I generally prefer rem, but I forgot to apply it in this project in many cases. And thanks for your feedback it was helpful.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord