Design comparison
Solution retrospective
Greetings all,
For me, Css was hard because HTML was not set-up correctly. For Example: where to place divs so it is would be easy to target in css. It took me a while to figured it out.
What is the best solution for adding bg-pattern imgs? Add in HTML or CSS? I know that profile pic must go in HTML for semantic reasons.
Any other comments and suggestion will be highly appreciated to improve my skills. Best regards, KT
Community feedback
- @kem522Posted almost 4 years ago
Hello there!
This looks good! As for your question about background images being in the HTML or CSS, generally all styling should be in the CSS unless for some reason it can't be (e.g images being dynamically added via JS) so the way you have done background images here is correct.
Another couple of bits and pieces:
- It's great that you've added alt text to your images, but you don't need to add the word 'pic' as it's already assumed your alt text is referring to an image.
- When using 0 values in your CSS you don't need to add px, em or rem at the end e.g
margin: 0
is just fine!
0@KtGitItPosted almost 4 years agoHi there!
Thanks for reply and suggestions. After reading your both advice, now I can recall the training I had about it. It does ring a bell now :)
0 - @RocTanweerPosted almost 4 years ago
Hello, Do you know about screenshots ? I don't know where to collect them.I clicked at an option but don't know where is that..
0@KtGitItPosted almost 4 years agoHey, same here. I just clicked and i have only 4 left but dont know what it does? where to collect them??
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord