HTML 5 css3

Community feedback

• 

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  Hello,

  Nice work !

  But there's some things to say ;)

  For the HTML, you don't need to use severals class name for similare content. Look the stats part, you've put 'first-element', 'second-element', etc. It's the same thing, so use the same class. It's better to work in CSS.

  Using of title. Is it really a title in stats? Maybe you could use a title for the category of the stats but not for the value, you should use a 'p'.

  If image wasn't here, you can understand the content, then it's background-image and a background-image shouldn't be paint in html but in css.

  For the CSS i notice that you used a lot of poisition property. It's not needed here, you could look around Flex-box, it's more aproriate.

  Hope that will help you. Keep coding and have a nice day.

  Marked as helpful

  0

  ---

  

  Chandra Shekhar Pawar•110

  @Shekharpawar1Posted over 3 years ago

  @AlexGDevPro thanks for the feedback would use the tips from the next projects. but can you help me with background image in css because when i use background image in css it does not render on the screen so i have to use html for that case also

  0

  

  Alex G•315

  @AlexGDevProPosted over 3 years ago

  @Shekharpawar1

  OK when I'll back on my pc I'll check the code and I'll try to help you.

  0
• 

  Saif Narpali•590

  @SaifN97Posted over 3 years ago

  Hey good job on this one! I'll suggest avoid using fix heights unless you really need one and look more into using rem and em units instead of pixels.. Hope this was helpful :)

  Marked as helpful

  0

  ---

  

  Chandra Shekhar Pawar•110

  @Shekharpawar1Posted over 3 years ago

  @SaifN97 thanks for feedback i would use it in next projects

  0