HSL Variables used

Community feedback

• 

  Devika Sujith•175

  @DCoder18Posted about 3 years ago

  Hi Michael, to answer your question, yes I think increasing the width of your container would definitely help. 16px wouldn't look too big then. I would also suggest making the height of your container auto and control the height using padding. This would help with responsiveness and you don't have to keep changing the height if you make a change to the width :)

  Secondly, instead of using divs for all your elements, I suggest using the appropriate HTML markup such as <h1> for headings, <p> for paragraphs etc. This is very important for accessibility and SEO. This will also fix majority of the accessibility issues mentioned in your report.

  Here are some ways you can fix those issues:

  • Change <div class="container"> to <main class="container">
  • Change <div class="attribution"> to <footer class="attribution"> and so on..

  Here is a helpful resource to understand more about semantic markup: Semantic Markup

  I know this is more than you asked for but I hope it helps anyway :)

  Marked as helpful

  1

  ---

  

  Michael Morrison•500

  @mjmorrison10Posted about 3 years ago

  @DCoder18 Thank you. I will make some adjustments. I'm relatively new and I don't really know how to make sure my solution is equal to the design.

  For the footer, I just left that as is from frontend-mentor. Didn't think it would matter to change it, but thanks for the suggestion. I'll keep that in mind.

  1