Design comparison
Community feedback
- @HassiaiPosted over 1 year ago
Replace <h2> with <h1> to fix the accessibility issue.
Always begin the heading of the html with <h1> tag because the <h1> is needed to make the content accessible, wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
Give the alt attribute in the img a value. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.
To center .product-container on the page, using flexbox, replace the height in .main-container with
min-height:100vh
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
1@amirbek887Posted over 1 year ago@Hassiai hi, thanks for your effort and time. Can you tell me why my code was able to become responsive, I don't fully understand the concept.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord